Improve fsspec DataPipe to accept extra keyword arguments #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
NivekT
approved these changes
Jun 3, 2022
Comment on lines
+96
to
+98
| else: | ||
| abs_path = file_name |
There was a problem hiding this comment.
Just to confirm - this never happens if is_local == True?
There was a problem hiding this comment.
Good question. I can't guarantee it since I am not aware of all use cases.Based on my experience on fsspec, I only encounter the problem when the input is s3 url.
For local files, I would trust the test here https://github.com/pytorch/data/blob/main/test/test_fsspec.py#L56-L65. As long as it doesn't break, I think
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ejguan
added a commit
to ejguan/data
that referenced
this pull request
Jun 7, 2022
Summary: Fixes pytorch#494 ### Changes - Add `kwargs` to all `DataPipe`s using `fsspec` - Fix a bug in `FSSpecFileLister` to prevent joining paths from the root path if the root path has already presented in the paths. - Add/Fix more tests I need this PR to test the performance between `fsspec` and native `s3` Pull Request resolved: pytorch#495 Reviewed By: NivekT Differential Revision: D36908570 Pulled By: ejguan fbshipit-source-id: 93da4c1c7e18012fb053799265375124d28a856c
ejguan
added a commit
that referenced
this pull request
Jun 7, 2022
Summary: Fixes #494 ### Changes - Add `kwargs` to all `DataPipe`s using `fsspec` - Fix a bug in `FSSpecFileLister` to prevent joining paths from the root path if the root path has already presented in the paths. - Add/Fix more tests I need this PR to test the performance between `fsspec` and native `s3` Pull Request resolved: #495 Reviewed By: NivekT Differential Revision: D36908570 Pulled By: ejguan fbshipit-source-id: 93da4c1c7e18012fb053799265375124d28a856c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #494
Changes
kwargsto allDataPipes usingfsspecFSSpecFileListerto prevent joining paths from the root path if the root path has already presented in the paths.I need this PR to test the performance between
fsspecand natives3